Minor: refactor probe check into function should_skip_aggregation
#11821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Aug 5, 2024
| .as_ref() | ||
| .is_some_and(|probe| probe.should_skip()) | ||
| { | ||
| } else if self.should_skip_aggregation() { |
There was a problem hiding this comment.
the main rationale is to pull this check into a function.
| // total number of unique groups. | ||
| // | ||
| // Note: currently spilling is not supported for Partial aggregation | ||
| /// Updates skip aggregation probe state. |
There was a problem hiding this comment.
drive by conversion to docstring style comments
Dandandan
approved these changes
Aug 6, 2024
|
Thank you @Dandandan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Follow on to #11627
Rationale for this change
Per https://github.com/apache/datafusion/pull/11627/files#r1694253923, I think embedding the aggregation probe logic into a function makes the code eaiser to understand
What changes are included in this PR?
should_skip_aggregation///from//for consistencyAre these changes tested?
Are there any user-facing changes?
No, this is all internal code organization