Use qualified aliases to simplify searching DFSchema #12546
Merged
+13
−27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A.
Rationale for this change
The following logic was introduced for
single_distinct_to_groupby
in #4050.The reason was the lack of alias-with-qualifier, which caused the qualifier to be lost after alias. See comment
When searching for a qualified name in DFSchema, we must also check unqualified fields because they may have been aliased and previously had a qualifier. We can now use qualified aliases to avoid this.
datafusion/datafusion/common/src/dfschema.rs
Lines 358 to 369 in 0243ebd
What changes are included in this PR?
Are these changes tested?
By existing tests.
Are there any user-facing changes?
No