Require Debug for AnalyzerRule, FunctionRewriter, and OptimizerRule
#12556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
logical-expr
alamb
commented
Sep 20, 2024
| @@ -100,6 +100,7 @@ pub async fn main() -> Result<()> { | |||
|
|
|||
| /// An example OptimizerRule that replaces all `col = <const>` predicates with a | |||
| /// user defined function | |||
| #[derive(Default, Debug)] | |||
There was a problem hiding this comment.
this is the end user visible change -- basically you have to #[derive(Debug)] if you haven't already
alamb
commented
Sep 20, 2024
| @@ -72,7 +74,7 @@ pub trait AnalyzerRule { | |||
| /// | |||
| /// An `Analyzer` transforms a `LogicalPlan` | |||
| /// prior to the rest of the DataFusion optimization process. | |||
| #[derive(Clone)] | |||
| #[derive(Clone, Debug)] | |||
There was a problem hiding this comment.
It will be nice to be able to see what rules are registered with the analyzer/optimizer
phillipleblanc
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #12555
Rationale for this change
I would like DataFusion to be easiser to configure and use, and having
Debugimpls forcommon structs would be a big help.
What changes are included in this PR?
DebugforAnalyzerRule,FunctionRewriter, andOptimizerRule#derivethis trait as necessaryAre these changes tested?
Yes buy CI and the compiler
Are there any user-facing changes?
Technically this is an API change as it also adds the requirement for Debug for various optimizer rules, but I think that is good thing.