Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fourth batch of updating sql tests to use assert_batches_eq #1280

Conversation

matthewmturner
Copy link
Contributor

Which issue does this PR close?

Continued work on #743 task 2.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the datafusion Changes in the datafusion crate label Nov 9, 2021
@matthewmturner
Copy link
Contributor Author

@alamb good for review when you're ready :)

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome -- thank you @matthewmturner ❤️

@alamb alamb merged commit 621fca4 into apache:master Nov 13, 2021
@alamb alamb changed the title WIP: Fourth batch of updating sql tests to use assert_batches_eq Fourth batch of updating sql tests to use assert_batches_eq Nov 13, 2021
@houqp houqp added the development-process Related to development process of DataFusion label Nov 13, 2021
matthewmturner added a commit to matthewmturner/arrow-datafusion that referenced this pull request Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datafusion Changes in the datafusion crate development-process Related to development process of DataFusion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants