Migrate documentation for regr* aggregate functions to code
#12871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
removed
documentation
github-actions
bot
added
documentation
alamb
commented
Oct 11, 2024
| @@ -76,23 +80,7 @@ impl Regr { | |||
| } | |||
| } | |||
|
|
|||
| /* | |||
There was a problem hiding this comment.
drive by clean up -- I don't know why this code was commented out
Omega359
reviewed
Oct 17, 2024
| Given input column Y and X: regr_slope(Y, X) returns the slope (k in Y = k*X + b) using minimal RSS fitting.", | ||
| ) | ||
| .with_syntax_example("regr_slope(expression_y, expression_x)") | ||
| .with_standard_argument("expression_y", "Expression") |
There was a problem hiding this comment.
This currently renders as Expression expression to operate on. Can be a constant, column, or function, and any combination of operators.
|
Beyond the one minor change this LGTM |
4 tasks
korowa
approved these changes
Oct 21, 2024
|
Thank you for the review @korowa |
|
🚀 let's do this. Thanks again @goldmedal and @korowa |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #12827
Rationale for this change
#12861 from @jonathanc-n moves some of the aggregate function documentation to the code, but the
regrfunctions are handled speciallyWhat changes are included in this PR?
Move
regr_*aggregate functions to codeAre these changes tested?
Yes y CI
Are there any user-facing changes?