Impl byte view column #12883
Closed
Impl byte view column #12883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
physical-expr
alamb
commented
Oct 11, 2024
| @@ -579,4 +897,153 @@ mod tests { | |||
| assert!(!builder.equal_to(4, &input_array, 4)); | |||
| assert!(builder.equal_to(5, &input_array, 5)); | |||
| } | |||
|
|
|||
| #[test] | |||
There was a problem hiding this comment.
perhaps these tests would be helpful @Rachelint
| @@ -5207,4 +5207,67 @@ NULL NULL 2 | |||
| NULL a 2 | |||
|
|
|||
| statement ok | |||
| drop table t; | |||
| drop table t | |||
There was a problem hiding this comment.
here are some end to end tests (maybe we just need to extend them for binary)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP some code I made for #12809 on the plan
Maybe there is some code here that will be useful
I don't expect this PR to be merged