Fifth batch of updating sql tests to use assert_batches_eq #1318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alamb i think this is the final batch and is ready for review :) FYI, i left some tests related to plans that were using |
alamb
approved these changes
Nov 19, 2021
There was a problem hiding this comment.
Thank you @matthewmturner 🎉
FYI, i left some tests related to plans that were using assert_eq as they were a bit more nuanced to update and i wanted to get the simple ones done first.
I think it is ok to leave the ones that need something different using assert_eq directly
Pretty soon our tests are going to look totally neat and organized 🎉
xudong963
pushed a commit
to xudong963/arrow-datafusion
that referenced
this pull request
Nov 28, 2021
* Updated tests * More tests * Final tests * Fix sql references
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Continued work on #743 task 2.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?