Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report current operation when coercion fails #13628

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Report current operation when coercion fails #13628

merged 1 commit into from
Dec 4, 2024

Conversation

findepi
Copy link
Member

@findepi findepi commented Dec 3, 2024

This makes for a more actionable error message.

@github-actions github-actions bot added the logical-expr Logical plan and expressions label Dec 3, 2024
@findepi findepi mentioned this pull request Dec 3, 2024
Closed
@github-actions github-actions bot added the optimizer Optimizer rules label Dec 3, 2024
@github-actions github-actions bot added the sqllogictest SQL Logic Tests (.slt) label Dec 3, 2024
alamb
alamb approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @findepi and @Weijun-H -- these are much nicer error messages 💯

datafusion/optimizer/src/analyzer/type_coercion.rs Outdated Show resolved Hide resolved
@findepi
Report current operation when coercion fails
c982a9b 
This makes for a more actionable error message.
@findepi findepi merged commit 55e56c4 into apache:main Dec 4, 2024
25 checks passed
@findepi findepi deleted the findepi/errctx branch December 4, 2024 12:18
@alamb alamb mentioned this pull request Dec 13, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Weijun-H Weijun-H Weijun-H left review comments

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
logical-expr Logical plan and expressions optimizer Optimizer rules sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@findepi @alamb @Weijun-H