feat: add support for LogicalPlan::DML(...) serde
#14079
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Jan 12, 2025
There was a problem hiding this comment.
Thank you @milenkovicm -- this looks great to me ❤️
It would be great if we could add a few more tests (as I noted) but I also think we could do it as a follow on too if you prefer
|
it should be resolved now, thanks @alamb |
|
Thanks again @milenkovicm 🚀 |
This was referenced Feb 10, 2025
rudlorenz
pushed a commit
to tarantool/datafusion
that referenced
this pull request
Aug 19, 2025
* Add support for DML serialization to proto closes: apache#13616 * add round trip test for DML serde * cover all cases in round trip test * minor: change ordering of enum type
rudlorenz
pushed a commit
to tarantool/datafusion
that referenced
this pull request
Aug 20, 2025
* Add support for DML serialization to proto closes: apache#13616 * add round trip test for DML serde * cover all cases in round trip test * minor: change ordering of enum type
rudlorenz
pushed a commit
to tarantool/datafusion
that referenced
this pull request
Aug 28, 2025
Basically it's sort of cherry-pick of apache#14079 from upstream
rudlorenz
pushed a commit
to tarantool/datafusion
that referenced
this pull request
Aug 29, 2025
Basically it's sort of cherry-pick of apache#14079 from upstream
rudlorenz
pushed a commit
to tarantool/datafusion
that referenced
this pull request
Sep 1, 2025
Basically it's a cherry-pick of two requests apache#14079 and apache#14631 from upstream
rudlorenz
pushed a commit
to tarantool/datafusion
that referenced
this pull request
Sep 2, 2025
Basically it's a cherry-pick of two requests apache#14079 and apache#14631 from upstream
rudlorenz
pushed a commit
to tarantool/datafusion
that referenced
this pull request
Sep 2, 2025
Basically it's a cherry-pick of two requests apache#14079 and apache#14631 from upstream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #13616.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?