Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding RowsReader and writer #14149

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
+688 −1
Open

adding RowsReader and writer #14149

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0e28e91
adding rowreader and writer
Lordworms Jan 16, 2025
eb54dc3
fix clippy
Lordworms Jan 16, 2025
347f10f
fix clippy
Lordworms Jan 16, 2025
d59d1c8
fix clippy
Lordworms Jan 16, 2025
5b70982
adding tests
Lordworms Jan 16, 2025
f68d962
add test
Lordworms Jan 19, 2025
8fdb6bd
refact
Lordworms Jan 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions datafusion/physical-plan/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ workspace = true

[features]
force_hash_collisions = []
compress = ["flate2"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

datafusion crate also has this dependency

datafusion/datafusion/core/Cargo.toml

Line 46 in e9a77e0

compression = ["xz2", "bzip2", "flate2", "zstd", "async-compression", "tokio-util"]

Is it possible to move the dependency to workspace level, to keep the version the same.
I think even the whole compression feature can be moved to the workspace level, if we want to support different compression for spilling 🤔 (we can do this in another PR)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that would be better


[lib]
name = "datafusion_physical_plan"
Expand All @@ -54,6 +55,7 @@ datafusion-expr = { workspace = true }
datafusion-functions-window-common = { workspace = true }
datafusion-physical-expr = { workspace = true, default-features = true }
datafusion-physical-expr-common = { workspace = true }
flate2 = { version = "1.0.35", optional = true }
futures = { workspace = true }
half = { workspace = true }
hashbrown = { workspace = true }
Expand All @@ -72,6 +74,7 @@ once_cell = "1.18.0"
rand = { workspace = true }
rstest = { workspace = true }
rstest_reuse = "0.7.0"
tempfile = { workspace = true }
tokio = { workspace = true, features = [
"rt-multi-thread",
"fs",
Expand Down
2 changes: 1 addition & 1 deletion datafusion/physical-plan/src/sorts/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@ mod cursor;
mod index;
mod merge;
pub mod partial_sort;
pub mod row_serde;
pub mod sort;
pub mod sort_preserving_merge;
mod stream;
pub mod streaming_merge;

pub use index::RowIndex;
Loading
Loading