Skip to content

Conversation

Owen-CH-Leung
Copy link
Contributor

@Owen-CH-Leung Owen-CH-Leung commented Jan 16, 2025

Further to the effort in #13663, this PR upgrades PyO3 to 0.23.3, arrow-rs to 54.0.0 and parquet to 54.0.0, and mark several deprecated functions as allow[deprecated] for further process.

@github-actions github-actions bot added physical-expr Changes to the physical-expr crates core Core DataFusion crate common Related to common crate proto Related to proto crate labels Jan 16, 2025
@Owen-CH-Leung Owen-CH-Leung marked this pull request as ready for review January 16, 2025 15:45
Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Owen-CH-Leung for your contribution, triggering the build

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Owen-CH-Leung -- this looks amazing 🤗

I think we can merge this PR and I will file some follow on tickets / etc for dealing with the #deprecated parts (and sorting out what we need to do to move off the deprecated functionality)

@alamb alamb changed the title Upgrade arrow-rs, parquet and pyo3 Upgrade arrow-rs, parquet to 54.0.0 and pyo3 to 0.23.3 Jan 17, 2025
@alamb alamb merged commit a407500 into apache:main Jan 17, 2025
30 checks passed
@alamb
Copy link
Contributor

alamb commented Jan 17, 2025

Thanks again @Owen-CH-Leung -- very much apprecaited

builder.set_column_max_statistics_size(path, max_statistics_size);
builder = {
#[allow(deprecated)]
builder.set_column_max_statistics_size(path, max_statistics_size)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

}
}

// TODO file a ticket about handling deprecated dict_id attributes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

common Related to common crate core Core DataFusion crate physical-expr Changes to the physical-expr crates proto Related to proto crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade to arrow-rs/parquet 54.0.0

3 participants