DFParser should skip unsupported COPY INTO #14382
Open
+26
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Feb 3, 2025
There was a problem hiding this comment.
Thank you @osipovartem -- this makes sense to me
Can you please fix the CI failure (I think you need to run cargo fmt locally and commit the result).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #14372
What changes are included in this PR?
This PR allows to skip COPY INTO statement which is not supported by DFParser.
COPY INTO already supported by native parser as a Statement::CopyIntoSnowflake
Are these changes tested?
Added some tests with snowflake dialect
Are there any user-facing changes?
No