Update REGEXP_MATCH scalar function to support Utf8View #14449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Feb 3, 2025
| } | ||
| } | ||
| pub fn regexp_match<T: OffsetSizeTrait>(args: &[ArrayRef]) -> Result<ArrayRef> { | ||
| pub fn regexp_match(args: &[ArrayRef]) -> Result<ArrayRef> { |
There was a problem hiding this comment.
I agree technically speaking this is an API change but I also think it is small and is ok. I will flag this PR as API change but I think it will be minimally disruptive
| @@ -783,7 +783,7 @@ EXPLAIN SELECT | |||
| FROM test; | |||
| ---- | |||
| logical_plan | |||
| 01)Projection: regexp_match(CAST(test.column1_utf8view AS Utf8), Utf8("^https?://(?:www\.)?([^/]+)/.*$")) AS k | |||
| 01)Projection: regexp_match(test.column1_utf8view, Utf8View("^https?://(?:www\.)?([^/]+)/.*$")) AS k | |||
| @@ -354,6 +377,29 @@ X | |||
| X | |||
| X | |||
|
|
|||
| # test string view | |||
There was a problem hiding this comment.
As discussed in #11911 (comment) it would be great to move these tests into string.slt but we can totally do it as a follow on as well
| @@ -621,7 +667,7 @@ CREATE TABLE t_stringview AS | |||
| SELECT arrow_cast(str, 'Utf8View') as str, arrow_cast(pattern, 'Utf8View') as pattern, arrow_cast(start, 'Int64') as start, arrow_cast(flags, 'Utf8View') as flags FROM t; | |||
|
|
|||
| query I | |||
| SELECT regexp_count(str, '\w') from t; | |||
| SELECT regexp_count(str, '\w') from t_stringview; | |||
There was a problem hiding this comment.
👍 this looks like a driveby fix
There was a problem hiding this comment.
yes, it was. Couldn't resist.
alamb
pushed a commit
to alamb/datafusion
that referenced
this pull request
Feb 3, 2025
* Update REGEXP_MATCH scalar function to support Utf8View * Cargo fmt fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #11911
Rationale for this change
Add support for utf8view to regexp_match function
What changes are included in this PR?
Code, tests, benchmarks.
Are these changes tested?
Yes
Are there any user-facing changes?
signature for regexp_match rust function (not the udf) changed to not include <T: OffsetSizeTrait>
I am unsure if that is an breaking api change or not. I suppose it should be.