Skip to content

Conversation

blaginin
Copy link
Contributor

@blaginin blaginin commented Feb 3, 2025

Which issue does this PR close?

Rationale for this change

We don't currently serialize parquet_options in ParquetExec

What changes are included in this PR?

Write and optionally parse the value in protobuf

Are these changes tested?

Yes, extended a round trip test

Are there any user-facing changes?

No

@github-actions github-actions bot added the proto Related to proto crate label Feb 3, 2025
@blaginin blaginin marked this pull request as ready for review February 4, 2025 17:59
@alamb alamb changed the title Serialize parquet_options Serialize parquet_options in datafusion-proto Feb 4, 2025
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @blaginin -- very nice Detective work 🕵️

FYI @robtandy

@robtandy
Copy link
Contributor

robtandy commented Feb 4, 2025

Amazing! Thank you so much @blaginin !

@alamb alamb merged commit 168fe49 into apache:main Feb 5, 2025
27 checks passed
@alamb
Copy link
Contributor

alamb commented Feb 5, 2025

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

proto Related to proto crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Query produces different results after physical plan round trip to bytes

3 participants