Speedup date_trunc (~20% time reduction)
#14593
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 10, 2025 22:23
date_trunc_minute_1000 time: [12.745 µs 12.794 µs 12.849 µs]
change: [-19.871% -19.544% -19.210%] (p = 0.00 <
0.05)
Performance has improved.
Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mild
remove todo
alamb
approved these changes
Feb 11, 2025
Dandandan
reviewed
Feb 11, 2025
| .collect::<Result<PrimitiveArray<T>>>()? | ||
| let array: PrimitiveArray<T> = array | ||
| .try_unary(|x| { | ||
| general_date_trunc(T::UNIT, x, parsed_tz, granularity.as_str()) |
There was a problem hiding this comment.
looking at the code, I think even more could be gained by having general_date_trunc operate on the array rather than per value.
There was a problem hiding this comment.
I can take a look at that. Would it be okay to do so in another PR?
Then we have the benchmark on main
There was a problem hiding this comment.
Yes, please do do so in a follow on PR -- let's leave this one as is
Thanks @simonvandel
Dandandan
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
I haven't looked at the generated code, but i presume that using
try_unarycan lead to better vectorization.What changes are included in this PR?
date_trunctry_unaryoveriter-mapcombo.Are these changes tested?
Using existing tests.
Are there any user-facing changes?
Faster
date_trunc