Consolidate feature flags into configuration guide #14657
Conversation
github-actions
bot
added
the
documentation
| - `compression`: reading files compressed with `xz2`, `bzip2`, `flate2`, and `zstd` | ||
| - `crypto_expressions`: cryptographic functions such as `md5` and `sha256` | ||
| - `datetime_expressions`: date and time functions such as `to_timestamp` | ||
| - `encoding_expressions`: `encode` and `decode` functions |
There was a problem hiding this comment.
There were also a few missing items here
| - `crypto_expressions`: cryptographic functions such as `md5` and `sha256` | ||
| - `datetime_expressions`: date and time functions such as `to_timestamp` | ||
| - `encoding_expressions`: `encode` and `decode` functions | ||
| - `math_expressions`: `sqrt` and other math functions |
There was a problem hiding this comment.
This doesn't appear to be in the defaults list here:
datafusion/datafusion/core/Cargo.toml
Line 49 in 40bb75f
There was a problem hiding this comment.
That was an excellent call. I fixed it in df190ad
However, I think since the subcrates already have their own default features, it is likely not possible to remove these various functon packages 🤔 maybe we should fix that in a following issue
| - `parquet`: support for reading the [Apache Parquet] format | ||
| - `regex_expressions`: regular expression functions, such as `regexp_match` | ||
| - `unicode_expressions`: Include unicode aware functions such as `character_length` | ||
| - `unparser`: enables support to reverse LogicalPlans back into SQL |
There was a problem hiding this comment.
This doesn't appear to be in the defaults list here:
datafusion/datafusion/core/Cargo.toml
Line 49 in 40bb75f
|
|
||
| ### Default features: | ||
|
|
||
| - `nested_expressions`: functions for working with nested type function such as `array_to_string` |
There was a problem hiding this comment.
Would this be better in alphabetical order?
There was a problem hiding this comment.
Great idea -- done in 6654168
| - `crypto_expressions`: cryptographic functions such as `md5` and `sha256` | ||
| - `datetime_expressions`: date and time functions such as `to_timestamp` | ||
| - `encoding_expressions`: `encode` and `decode` functions | ||
| - `math_expressions`: `sqrt` and other math functions |
There was a problem hiding this comment.
That was an excellent call. I fixed it in df190ad
However, I think since the subcrates already have their own default features, it is likely not possible to remove these various functon packages 🤔 maybe we should fix that in a following issue
|
|
||
| ### Default features: | ||
|
|
||
| - `nested_expressions`: functions for working with nested type function such as `array_to_string` |
There was a problem hiding this comment.
Great idea -- done in 6654168
|
Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days. |
|
This is a good ticket and shouldn't be autoclosed. |
|
Yeah it just needs a committer to review I think |
3 participants
Which issue does this PR close?
Rationale for this change
I am trying to improve the docs (inspired by recent PRs)
Let's try and consolidate as much of the documentation into the same set of docs so it isn't spread all over
What changes are included in this PR?
Are these changes tested?
I tested them manually
Are there any user-facing changes?