Add example for LogicalPlanBuilder::insert_into
#14663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
sql
alamb
force-pushed
the
alamb/insert_into_doc
branch
from
09a6d8c to
d648c8a
Compare
comphead
approved these changes
Feb 16, 2025
|
Thanks @comphead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
targettoDmlStatement(to eliminate need for table lookup after deserialization) #14631 from @milenkovicmRationale for this change
As we eveolve the API having more examples is better. I was reviewing this code anyways so figured I would hack up a doc example (especially as it now needs a TableSource which is somewhat confusing)
I also think since we are going to change the API having an example to help people migrate will be nice
What changes are included in this PR?
LogicalPlanBuilder::insert_intoAre these changes tested?
Yes docs CI
Are there any user-facing changes?
Just docs, no functional changes