Skip to content

chore: migrate invoke_batch to invoke_with_args for unicode function #14856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 24, 2025
Merged

chore: migrate invoke_batch to invoke_with_args for unicode function #14856

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions datafusion/functions/src/unicode/character_length.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,12 +88,11 @@ impl ScalarUDFImpl for CharacterLengthFunc {
utf8_to_int_type(&arg_types[0], "character_length")
}

fn invoke_batch(
fn invoke_with_args(
&self,
args: &[ColumnarValue],
_number_rows: usize,
args: datafusion_expr::ScalarFunctionArgs,
) -> Result<ColumnarValue> {
make_scalar_function(character_length, vec![])(args)
make_scalar_function(character_length, vec![])(&args.args)
}

fn aliases(&self) -> &[String] {
Expand Down
6 changes: 3 additions & 3 deletions datafusion/functions/src/unicode/initcap.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,11 +87,11 @@ impl ScalarUDFImpl for InitcapFunc {
}
}

fn invoke_batch(
fn invoke_with_args(
&self,
args: &[ColumnarValue],
_number_rows: usize,
args: datafusion_expr::ScalarFunctionArgs,
) -> Result<ColumnarValue> {
let args = &args.args;
match args[0].data_type() {
DataType::Utf8 => make_scalar_function(initcap::<i32>, vec![])(args),
DataType::LargeUtf8 => make_scalar_function(initcap::<i64>, vec![])(args),
Expand Down
6 changes: 3 additions & 3 deletions datafusion/functions/src/unicode/left.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,11 +97,11 @@ impl ScalarUDFImpl for LeftFunc {
utf8_to_str_type(&arg_types[0], "left")
}

fn invoke_batch(
fn invoke_with_args(
&self,
args: &[ColumnarValue],
_number_rows: usize,
args: datafusion_expr::ScalarFunctionArgs,
) -> Result<ColumnarValue> {
let args = &args.args;
match args[0].data_type() {
DataType::Utf8 | DataType::Utf8View => {
make_scalar_function(left::<i32>, vec![])(args)
Expand Down
6 changes: 3 additions & 3 deletions datafusion/functions/src/unicode/lpad.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,11 +109,11 @@ impl ScalarUDFImpl for LPadFunc {
utf8_to_str_type(&arg_types[0], "lpad")
}

fn invoke_batch(
fn invoke_with_args(
&self,
args: &[ColumnarValue],
_number_rows: usize,
args: datafusion_expr::ScalarFunctionArgs,
) -> Result<ColumnarValue> {
let args = &args.args;
match args[0].data_type() {
Utf8 | Utf8View => make_scalar_function(lpad::<i32>, vec![])(args),
LargeUtf8 => make_scalar_function(lpad::<i64>, vec![])(args),
Expand Down
6 changes: 3 additions & 3 deletions datafusion/functions/src/unicode/reverse.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,11 +85,11 @@ impl ScalarUDFImpl for ReverseFunc {
utf8_to_str_type(&arg_types[0], "reverse")
}

fn invoke_batch(
fn invoke_with_args(
&self,
args: &[ColumnarValue],
_number_rows: usize,
args: datafusion_expr::ScalarFunctionArgs,
) -> Result<ColumnarValue> {
let args = &args.args;
match args[0].data_type() {
Utf8 | Utf8View => make_scalar_function(reverse::<i32>, vec![])(args),
LargeUtf8 => make_scalar_function(reverse::<i64>, vec![])(args),
Expand Down
6 changes: 3 additions & 3 deletions datafusion/functions/src/unicode/right.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,11 +97,11 @@ impl ScalarUDFImpl for RightFunc {
utf8_to_str_type(&arg_types[0], "right")
}

fn invoke_batch(
fn invoke_with_args(
&self,
args: &[ColumnarValue],
_number_rows: usize,
args: datafusion_expr::ScalarFunctionArgs,
) -> Result<ColumnarValue> {
let args = &args.args;
match args[0].data_type() {
DataType::Utf8 | DataType::Utf8View => {
make_scalar_function(right::<i32>, vec![])(args)
Expand Down
6 changes: 3 additions & 3 deletions datafusion/functions/src/unicode/rpad.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,11 +108,11 @@ impl ScalarUDFImpl for RPadFunc {
utf8_to_str_type(&arg_types[0], "rpad")
}

fn invoke_batch(
fn invoke_with_args(
&self,
args: &[ColumnarValue],
_number_rows: usize,
args: datafusion_expr::ScalarFunctionArgs,
) -> Result<ColumnarValue> {
let args = &args.args;
match (
args.len(),
args[0].data_type(),
Expand Down
7 changes: 3 additions & 4 deletions datafusion/functions/src/unicode/strpos.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,12 +83,11 @@ impl ScalarUDFImpl for StrposFunc {
utf8_to_int_type(&arg_types[0], "strpos/instr/position")
}

fn invoke_batch(
fn invoke_with_args(
&self,
args: &[ColumnarValue],
_number_rows: usize,
args: datafusion_expr::ScalarFunctionArgs,
) -> Result<ColumnarValue> {
make_scalar_function(strpos, vec![])(args)
make_scalar_function(strpos, vec![])(&args.args)
}

fn aliases(&self) -> &[String] {
Expand Down
7 changes: 3 additions & 4 deletions datafusion/functions/src/unicode/substr.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,12 +95,11 @@ impl ScalarUDFImpl for SubstrFunc {
Ok(DataType::Utf8View)
}

fn invoke_batch(
fn invoke_with_args(
&self,
args: &[ColumnarValue],
_number_rows: usize,
args: datafusion_expr::ScalarFunctionArgs,
) -> Result<ColumnarValue> {
make_scalar_function(substr, vec![])(args)
make_scalar_function(substr, vec![])(&args.args)
}

fn aliases(&self) -> &[String] {
Expand Down
7 changes: 3 additions & 4 deletions datafusion/functions/src/unicode/substrindex.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,12 +108,11 @@ impl ScalarUDFImpl for SubstrIndexFunc {
utf8_to_str_type(&arg_types[0], "substr_index")
}

fn invoke_batch(
fn invoke_with_args(
&self,
args: &[ColumnarValue],
_number_rows: usize,
args: datafusion_expr::ScalarFunctionArgs,
) -> Result<ColumnarValue> {
make_scalar_function(substr_index, vec![])(args)
make_scalar_function(substr_index, vec![])(&args.args)
}

fn aliases(&self) -> &[String] {
Expand Down
7 changes: 3 additions & 4 deletions datafusion/functions/src/unicode/translate.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,12 +95,11 @@ impl ScalarUDFImpl for TranslateFunc {
utf8_to_str_type(&arg_types[0], "translate")
}

fn invoke_batch(
fn invoke_with_args(
&self,
args: &[ColumnarValue],
_number_rows: usize,
args: datafusion_expr::ScalarFunctionArgs,
) -> Result<ColumnarValue> {
make_scalar_function(invoke_translate, vec![])(args)
make_scalar_function(invoke_translate, vec![])(&args.args)
}

fn documentation(&self) -> Option<&Documentation> {
Expand Down