Update regenerate sql dep, revert runner changes. #14901
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Feb 26, 2025
|
I would like to try this out locally too but am on a train now so can't until later today |
|
I just tested this locally and it compiled and ran (and consumed a bunch of CPU) just great 👍 I also filed a follow on ticket to make this process better: |
|
Thanks again @Omega359 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
The forked sqllogictest-rs dependency required for the regenerate_sqlite_file.sh script was out of date and required updating. This PR updates DF to use the latest hash with the update in that fork.
What changes are included in this PR?
Script update. Commented the dependency in Cargo.toml to indicate to run the regenerate script prior to updating the sqllogictest-rs dependency.
Are these changes tested?
regenerate script ran successfully with the changes.
Are there any user-facing changes?
No.