Skip to content

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Feb 28, 2025

Which issue does this PR close?

Rationale for this change

When we remove the unescaping from datafusion-cli I think it is important to document how to properly used escaped values

What changes are included in this PR?

  1. Add documentation about escaping
  2. Add a slt test showing E strings working

Are these changes tested?

I reviewed the changes locally:

Screenshot 2025-02-28 at 7 13 01 AM
Screenshot 2025-02-28 at 7 13 24 AM

Are there any user-facing changes?

@alamb alamb marked this pull request as ready for review February 28, 2025 12:22
@github-actions github-actions bot added documentation Improvements or additions to documentation sqllogictest SQL Logic Tests (.slt) labels Feb 28, 2025
Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks @alamb

@alamb
Copy link
Contributor Author

alamb commented Feb 28, 2025

Thank you for the review @comphead

@alamb alamb merged commit f9f256c into apache:main Feb 28, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants