Implement tree explain for HashJoinExec
#15079
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2010YOUY01
reviewed
Mar 8, 2025
| let on = self | ||
| .on | ||
| .iter() | ||
| .map(|(c1, c2)| format!("({}, {})", c1, c2)) |
There was a problem hiding this comment.
I think formatting this join condition as 'c1 = c1' is easier to understand.
Maybe also concat multiple join condition with '\n' instead of ',' ?
There was a problem hiding this comment.
In the render tree, each line is parsed to extract key and value. If we add '\n' in the value, it will be treated as a new line.
There was a problem hiding this comment.
c1 = c1 is clearer than before! 👍
alamb
approved these changes
Mar 8, 2025
There was a problem hiding this comment.
Thank you @irenjj adn @2010YOUY01
I have some small suggestions but I don't think they are necessary
| .join(", "); | ||
|
|
||
| writeln!(f, "join_type={:?}", self.join_type)?; | ||
| writeln!(f, "on=[{}]", on) |
There was a problem hiding this comment.
I recommend
- we remove
[and] - don't print
join_typeif the type isInner
|
|
||
| # Query with hash join. | ||
| query TT | ||
| explain select * from table1 inner join table2 on table1.int_col = table2.int_col and table1.string_col = table2.string_col; |
There was a problem hiding this comment.
Recommend testing outer join here:
Suggested change
| explain select * from table1 inner join table2 on table1.int_col = table2.int_col and table1.string_col = table2.string_col; | |
| explain select * from table1 outer inner join table2 on table1.int_col = table2.int_col and table1.string_col = table2.string_col; |
|
Thanks again @irenjj |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
treeexplain forHashJoinExec#15078Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?