Ship Cargo.lock in the source distribution #1508
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Alright, I'll reopen the PR over there, thanks @alamb! |
|
Hm, it looks like github actions hasn't been set up for that repo, so I'll leave this PR open for now. |
jimexist
reviewed
Jan 1, 2022
| @@ -77,6 +77,9 @@ jobs: | |||
| - name: Build Python package | |||
| run: maturin build --release --no-sdist --strip | |||
|
|
|||
| - name: Check that the lock file is up to date | |||
| run: git diff --exit-code Cargo.lock | |||
There was a problem hiding this comment.
can you use --frozen and --locked per doc
There was a problem hiding this comment.
Yep, great idea. Thanks
|
after #1518 is merged please consider merging to that repo instead. thanks! |
|
Ok, thanks. I'll just proactively move it over |
|
Closing in favor of datafusion-contrib/datafusion-python#7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
It doesn't close an issue as far as I know.
Rationale for this change
Build systems like
nixneedCargo.lockto build reproducible Rust packages.The
Cargo.lockfile is necessary to generate a hash for a crate's dependencies.Without the
What changes are included in this PR?
Cargo.lockresulting from runningmaturin buildpyproject.tomlto ship theCargo.lockin the source distributionAre there any user-facing changes?
No API changes.
Does user-facing mean only API changes?