implement tree explain for GlobalLimitExec #15100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irenjj
reviewed
Mar 9, 2025
| writeln!(f, "skip={}", self.skip)?; | ||
| write!( | ||
| f, | ||
| "fetch={}", |
There was a problem hiding this comment.
Thanks @zjregee for the efforts,Here are some of my suggestions:
I think limit=xxx is more reasonable, and if fetch is None, maybe we don't need to print it.
There was a problem hiding this comment.
THat would also be consistent with the other operators that print out limit
There was a problem hiding this comment.
Updated and thanks for suggestions.
|
I also ran the tests locally and made sure they still passed after a merge from main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
treeexplain forGlobalLimitExec#15026.Rationale for this change
What changes are included in this PR?
Implement tree explain for
GlobalLimitExec.Are these changes tested?
Yes.
Are there any user-facing changes?
None.