Skip to content

Conversation

irenjj
Copy link
Contributor

@irenjj irenjj commented Mar 10, 2025

Which issue does this PR close?

Rationale for this change

To make the extra_info compatible with more formats.

What changes are included in this PR?

Enable parsing both key-value format and single key format.

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the sqllogictest SQL Logic Tests (.slt) label Mar 10, 2025
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @irenjj 🙏

I also took the liberty of adding some additional comments and fixing the display of CrossJoin

34)┌─────────────┴─────────────┐
35)│ LazyMemoryExec │
36)└───────────────────────────┘
26)│ v1@0 ASC NULLS LAST │
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that is very nice

@alamb alamb merged commit 9382add into apache:main Mar 10, 2025
24 checks passed
@irenjj
Copy link
Contributor Author

irenjj commented Mar 11, 2025

Thank you for helping me revise the question! @alamb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve Parsing for KV Format in tree explain.

2 participants