Skip to content

Conversation

irenjj
Copy link
Contributor

@irenjj irenjj commented Mar 12, 2025

Which issue does this PR close?

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the sqllogictest SQL Logic Tests (.slt) label Mar 12, 2025
Comment on lines +1634 to +1636
01)┌───────────────────────────┐
02)│ DataSinkExec │
03)└─────────────┬─────────────┘
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How we can construct a test case to print non-empty file_groups?🤔

Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks @irenjj

@comphead comphead merged commit 5f72234 into apache:main Mar 12, 2025
24 checks passed
@irenjj
Copy link
Contributor Author

irenjj commented Mar 12, 2025

Thanks @comphead ❤️

@irenjj irenjj deleted the explain_jsonsink branch March 12, 2025 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement tree explain for JsonSink

2 participants