Skip to content

Implement tree explain for LazyMemoryExec #15187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2025
Merged

Implement tree explain for LazyMemoryExec #15187

merged 1 commit into from
Mar 13, 2025

Conversation

@zebsme
Copy link
Contributor

@zebsme zebsme commented Mar 12, 2025 •
edited
Loading

Which issue does this PR close?

Rationale for this change

What changes are included in this PR?

  • Implement LazyMemoryExec
  • Update related tests

Are these changes tested?

Yes

Are there any user-facing changes?

No

@github-actions github-actions bot added the sqllogictest SQL Logic Tests (.slt) label Mar 12, 2025
@zebsme
Copy link
Contributor Author

zebsme commented Mar 12, 2025 •
edited
Loading

hi @alamb should this formatting look better?

+-------------+-------------+ 
|       LazyMemoryExec      | 
|    --------------------   | 
|      generate_series:     | 
|     start=1, end=1000,    | 
|       batch_size=8192     | 
+---------------------------+

alamb
alamb approved these changes Mar 12, 2025
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR @zebsme

I left some suggestions, but I also think this PR could be merged as is and we could improve it as a follow on PR

Thanks again

@zebsme
Copy link
Contributor Author

zebsme commented Mar 13, 2025 •
edited
Loading

hi @alamb

Added TODO comment and conflicts resolved

Thanks for suggestion :)

@Weijun-H Weijun-H merged commit ce536c9 into apache:main Mar 13, 2025
26 checks passed
@Weijun-H
Copy link
Member

Ship it and improve it in the follow-up. Thanks @zebsme and @alamb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alamb alamb alamb approved these changes

@Weijun-H Weijun-H Weijun-H approved these changes

Assignees

No one assigned

Labels

sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement tree explain for LazyMemoryExec

3 participants

@zebsme @Weijun-H @alamb