Skip to content

Conversation

shruti2522
Copy link
Contributor

@shruti2522 shruti2522 commented Mar 14, 2025

Which issue does this PR close?

Rationale for this change

What changes are included in this PR?

add OutputStreamStruct to avoid dead code in datafusion-cli printing logic

Are these changes tested?

Are there any user-facing changes?

@matthewmturner
Copy link
Contributor

I only had time to take a quick glance - but could this functionality be added to datafusion so it could be used by other apps that have CLIs built on datafusion?

@alamb
Copy link
Contributor

alamb commented Mar 17, 2025

I only had time to take a quick glance - but could this functionality be added to datafusion so it could be used by other apps that have CLIs built on datafusion?

Seems like a good idea, though would require some refactoring

There is a pretty large PR from @zhuqi-lucas here that I haven't had a chance to re-review

Maybe if we are preparing to pull it out into its own library, that might make a cleaner interface more important...

Copy link

Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale PR has not had any activity for some time label May 17, 2025
@github-actions github-actions bot closed this Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Stale PR has not had any activity for some time

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Code clean for new datafusion-cli streaming printing logic

3 participants