Simplify the printing of all plans containing expr in tree mode
#15249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
physical-expr
alamb
approved these changes
Mar 16, 2025
| DisplayFormatType::TreeRender => { | ||
| if let Some(predicate) = self.predicate() { | ||
| writeln!(f, "predicate={predicate}")?; | ||
| writeln!(f, "predicate={}", fmt_sql(predicate.as_ref()))?; |
| }) | ||
| .collect() | ||
| }; | ||
| // TODO: Implement `fmt_sql` for `AggregateFunctionExpr`. |
There was a problem hiding this comment.
perhaps we can make a follow on ticket for this
There was a problem hiding this comment.
I'm trying to resolve it, filed #15252.
WindowAggExpr seems have a similar problem🤔.
| 09)│ -------------------- │ | ||
| 10)│ predicate: │ | ||
| 11)│ string_col@1 != foo │ | ||
| 11)│ string_col != foo │ |
| 16)│ predicate: │ | ||
| 17)│ ticker@1 = A │ | ||
| 04)│ date ASC NULLS LAST, │ | ||
| 05)│ │ |
There was a problem hiding this comment.
it is somewhat strange to me there is an extra newline. Is that something we can remove?
There was a problem hiding this comment.
That was an issue I introduced in SortPreservingMergeExec 😭, has been fixed in the latest update.
| 15)│ FilterExec │ | ||
| 16)│ -------------------- │ | ||
| 17)│ predicate: │ | ||
| 18)│ ticker = A AND CAST(time │ |
There was a problem hiding this comment.
this looks so nice
(I am using that image a lot recently 🤔 )
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
|
Thanks @alamb for your review. |
|
Thanks again @irenjj -- merging this one in to unblock the next in the sequence |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
exprintreemode. #15238Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?