Skip to content

Implement tree explain for PlaceholderRowExec #15270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2025
Merged

Implement tree explain for PlaceholderRowExec #15270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions datafusion/physical-plan/src/placeholder_row.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,10 +113,7 @@ impl DisplayAs for PlaceholderRowExec {
write!(f, "PlaceholderRowExec")
}

DisplayFormatType::TreeRender => {
// TODO: collect info
write!(f, "")
}
DisplayFormatType::TreeRender => Ok(()),
}
}
}
Expand Down
14 changes: 14 additions & 0 deletions datafusion/sqllogictest/test_files/explain_tree.slt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2051,3 +2051,17 @@ physical_plan
31)│ infinite: true │
32)│ limit: None │
33)└───────────────────────────┘

# Test explain tree for PlaceholderRowExec
query TT
EXPLAIN select count(*) from (values ('a', 'b'), ('c', 'd')) as t (c1, c2)
----
physical_plan
01)┌───────────────────────────┐
02)│ ProjectionExec │
03)│ -------------------- │
04)│ count(*): 2 │
05)└─────────────┬─────────────┘
06)┌─────────────┴─────────────┐
07)│ PlaceholderRowExec │
08)└───────────────────────────┘