Implement GroupsAccumulator for min/max Duration #15322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
sqllogictest
shruti2522
changed the title
shruti2522
changed the title
shruti2522
force-pushed
the
groups_accumulator-duration
branch
4 times, most recently
from
876425e to
d853365
Compare
shruti2522
changed the title
shruti2522
force-pushed
the
groups_accumulator-duration
branch
from
8ef8afc to
406aa8b
Compare
alamb
reviewed
Mar 20, 2025
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thanks @shruti2522 -- this looks great -- I think it just needs one more change
| Timestamp(Nanosecond, _) => { | ||
| primitive_max_accumulator!(data_type, i64, TimestampNanosecondType) | ||
| } | ||
| Duration(Second) => { |
Contributor
There was a problem hiding this comment.
I think you need to add Duration to the list of types supported in groups_accumulator_supported as well.
shruti2522
commented
Mar 20, 2025
| | Binary | ||
| | LargeBinary | ||
| | BinaryView | ||
| | Duration(_) |
Contributor
Author
There was a problem hiding this comment.
I think you need to add
Durationto the list of types supported ingroups_accumulator_supportedas well.
Hi @alamb, I have added it here and similarly for Min
Contributor
There was a problem hiding this comment.
sorry -- I didn't see that for some reason. Thank you 🙏
alamb
approved these changes
Mar 21, 2025
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you @shruti2522 -- looks great 🙏
emilk
pushed a commit
to rerun-io/arrow-datafusion
that referenced
this pull request
Apr 1, 2025
emilk
pushed a commit
to rerun-io/arrow-datafusion
that referenced
this pull request
Apr 1, 2025
emilk
pushed a commit
to rerun-io/arrow-datafusion
that referenced
this pull request
Apr 1, 2025
avantgardnerio
pushed a commit
to coralogix/arrow-datafusion
that referenced
this pull request
Oct 1, 2025
avantgardnerio
pushed a commit
to coralogix/arrow-datafusion
that referenced
this pull request
Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Yes
Are there any user-facing changes?
Yes