Minor: Keep debug symbols for release-nonlto build
#15350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I personally just added a 'profiling' profile that inherits release-nonlto and set debug to true. |
zhuqi-lucas
approved these changes
Mar 21, 2025
Contributor
zhuqi-lucas
left a comment
zhuqi-lucas
left a comment
There was a problem hiding this comment.
LGTM, thanks!
I test it in my mac m4, it works for me.
comphead
approved these changes
Mar 21, 2025
Contributor
comphead
left a comment
comphead
left a comment
There was a problem hiding this comment.
Thanks @2010YOUY01 that makes for non LTO release to keep symbols to get the debugging.
Contributor
thats another option yes, A small concern about local profile is having deals with conflicts every time the toml file is updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
release-nonltobuild produces binaries with performance close to--releasebuild, but compiles faster. This compilation profile is used for easier development and benchmarking.Now it by default strips the debug symbols, as a consequence, If a flamegraph is collected using this
release-nonltobuild, useful function names will not displayed.Reproducer:
sudo cargo flamegraph --profile release-nonlto --bin dfbench -- sort-tpch -p /Users/yongting/Code/datafusion/benchmarks/data/tpch_sf10 -q 3The generated flamegraph will look like:
If we keep the symbol names, the flamegraph will be generated with function names in the call stack.
What changes are included in this PR?
Changed
cargo.tomlto keep debug symbols inrelease-nonltobuild.Are these changes tested?
Tested manually in the above example.
Are there any user-facing changes?
No.