Skip to content

Conversation

findepi
Copy link
Member

@findepi findepi commented Mar 24, 2025

The commit is reverted sans the SLT test added there.

Which issue does this PR close?

Rationale for this change

This reverts commit 0f4b8b1 (#13953). The commit improved performance at the cost of a regression (#15384).

What changes are included in this PR?

Are these changes tested?

SLT

Are there any user-facing changes?

yes

findepi added 2 commits March 24, 2025 12:48
)"

This reverts commit 0f4b8b1. The commit
improved performance at the cost of a regression.

The commit is reverted sans the SLT test added there.
@github-actions github-actions bot added physical-expr Changes to the physical-expr crates sqllogictest SQL Logic Tests (.slt) labels Mar 24, 2025
@findepi findepi marked this pull request as draft March 24, 2025 12:00
@findepi findepi closed this Mar 24, 2025
@findepi findepi deleted the findepi/lazy-case-revert branch March 24, 2025 12:00
@findepi
Copy link
Member Author

findepi commented Mar 24, 2025

superseded by #15390

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

physical-expr Changes to the physical-expr crates sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression: eager evaluation of expressions inside CASE conditional expression

1 participant