Migrate Optimizer tests to insta, part1 #15446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Mar 30, 2025
There was a problem hiding this comment.
Thank you @qstommyshu -- this is going to make maintaining these tests so much easier
This was referenced Apr 28, 2025
qstommyshu
changed the title
nirnayroy
pushed a commit
to nirnayroy/datafusion
that referenced
this pull request
May 2, 2025
* feat: Add `insta` crate as a dependency in Cargo files * Migrate optimizer integration tests to insta * taplo format --------- Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
This was referenced May 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
insta#15396 .Rationale for this change
What changes are included in this PR?
Migrated tests in
datafusion/core/tests/optimizerto use insta.Are these changes tested?
Yes, I manually tested the before/after changes.
Are there any user-facing changes?
No