Skip to content

Conversation

acking-you
Copy link
Contributor

Which issue does this PR close?

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@alamb alamb changed the title add extend sql for issue-11212 Add query to extended clickbench suite for "complex filter" Mar 31, 2025
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @acking-you

@alamb alamb merged commit 818e739 into apache:main Mar 31, 2025
28 checks passed
@Omega359
Copy link
Contributor

I am seeing the sql_planner benchmark now failing after this was merged.

Benchmarking physical_plan_clickbench_q50
Benchmarking physical_plan_clickbench_q50: Warming up for 3.0000 s

thread 'main' panicked at datafusion/core/benches/sql_planner.rs:60:14:
called `Result::unwrap()` on an `Err` value: Context("type_coercion", Plan("Internal error: Expect TypeSignatureClass::Native(LogicalType(Native(String), String)) but received NativeType::Binary, DataType: BinaryView.\nThis was likely caused by a bug in DataFusion's code and we would welcome that you file an bug report in our issue tracker No function matches the given name and argument types 'levenshtein(BinaryView, BinaryView)'. You might need to add explicit type casts.\n\tCandidate functions:\n\tlevenshtein(Coercion(TypeSignatureClass::Native(LogicalType(Native(String), String))), Coercion(TypeSignatureClass::Native(LogicalType(Native(String), String))))"))

@Omega359
Copy link
Contributor

Omega359 commented Mar 31, 2025

I think we may need to augment the github extended tests to run all the benchmarks, not to validate the results (though we can do that later) but to just make sure the benchmarks still run after a commit. Too many failures without the automated testing.

Edit: filed as #15511

@alamb
Copy link
Contributor

alamb commented Apr 1, 2025

I think we may need to augment the github extended tests to run all the benchmarks, not to validate the results (though we can do that later) but to just make sure the benchmarks still run after a commit. Too many failures without the automated testing.

Yeah -- thanks

I'll file a ticket for the actual error tomorrow.

We should also add real tests for those clickbench queries too 🤔

nirnayroy pushed a commit to nirnayroy/datafusion that referenced this pull request May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants