Extract tokio runtime creation from hot loop in benchmarks #15508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Mar 31, 2025
Contributor
|
🤔 this PR now appears to have some conflicts that need to be resolved |
Contributor
Author
|
I'll fix the conflicts in a bit, running benchmarks atm. |
…mprovement # Conflicts: # datafusion/core/benches/distinct_query_sql.rs # datafusion/core/benches/topk_aggregate.rs
nirnayroy
pushed a commit
to nirnayroy/datafusion
that referenced
this pull request
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Improve benchmarks
What changes are included in this PR?
Benchmark updates.
Are these changes tested?
Some benchmarks still fail (#15367) however everything else seems to run ok.
Are there any user-facing changes?
No.