Skip to content

Conversation

@Jiashu-Hu
Copy link
Contributor

@Jiashu-Hu Jiashu-Hu commented Mar 31, 2025

Which issue does this PR close?

Rationale for this change

The Decimal support in DataFusion was marked as complete in Issue #3523 on November 21, 2024. However, the user guide documentation (docs/source/user-guide/sql/data_types.md) still labels it as "experimental," which is outdated and misleading. This PR updates the documentation to reflect the current status, improving user understanding and trust in the Decimal functionality.

What changes are included in this PR?

  • Updated the Numeric Types section in docs/source/user-guide/sql/data_types.md to remove the "experimental" label for DECIMAL(precision, scale).
  • Replaced the note with: "Decimal support has been fully implemented“
  • Retained the link to [EPIC] Add Decimal support #3523 for historical context.

Are these changes tested?

No tests are included in this PR because it only modifies documentation

Are there any user-facing changes?

Yes, this PR updates the user-facing documentation at https://datafusion.apache.org/user-guide/sql/data_types.html. It clarifies that Decimal support is fully implemented, removing the outdated "experimental" label. No code or API changes are involved.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Mar 31, 2025
@Jiashu-Hu Jiashu-Hu changed the title update note Update user guide to note decimal is not experimental anymore Mar 31, 2025
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Jiashu-Hu

I don't think we even need to note that Decimal is complete (it is implied by its presence on this table)

Would you be willing to remove the entire Notes column?

@Jiashu-Hu
Copy link
Contributor Author

Thanks @Jiashu-Hu

I don't think we even need to note that Decimal is complete (it is implied by its presence on this table)

Would you be willing to remove the entire Notes column?

Thank you for your review! I have removed the item as you suggested and committed the latest version.

It appears that the shutdown of "GitHub Cache Storage" is causing the CI to fail. I believe we may need to update the sccache configuration to get it running again.
image
official documentation: https://gh.io/gha-cache-sunset

@alamb
Copy link
Contributor

alamb commented Apr 1, 2025

@Omega359 fixed this in the following PR I believe:

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @Jiashu-Hu

@alamb alamb merged commit 7b2d704 into apache:main Apr 1, 2025
5 of 6 checks passed
nirnayroy pushed a commit to nirnayroy/datafusion that referenced this pull request May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update user guide to note decimal is not experimental anymore

2 participants