fix: update group by columns for merge phase after spill #15531
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rluvaton
force-pushed
the
reproduce-single-error
branch
from
3fabcc4 to
ae94ef4
Compare
|
The CI failures are infra related... |
comphead
reviewed
Apr 2, 2025
comphead
approved these changes
Apr 2, 2025
Co-authored-by: Oleks V <comphead@users.noreply.github.com>
39 tasks
alamb
approved these changes
Apr 2, 2025
There was a problem hiding this comment.
Thanks @rluvaton and @comphead
FYI @2010YOUY01 who is working on spilling and @korowa who worked on the code in question
alamb
reviewed
Apr 2, 2025
|
Thank you @rluvaton |
nirnayroy
pushed a commit
to nirnayroy/datafusion
that referenced
this pull request
May 2, 2025
* fix: update group by columns for merge phase after spill fixes apache#15530 * Update datafusion/physical-plan/src/aggregates/row_hash.rs Co-authored-by: Oleks V <comphead@users.noreply.github.com> * move test to aggregate_fuzz --------- Co-authored-by: Oleks V <comphead@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
AggregateMode::Single#15530.Rationale for this change
I think the PR below forgot to update the group by expressions:
What changes are included in this PR?
Update group by columns to be based on their index for merging phase
Are these changes tested?
Yes
Are there any user-facing changes?
No