Add disk usage limit configuration to datafusion-cli #15586
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
2010YOUY01
approved these changes
Apr 5, 2025
There was a problem hiding this comment.
Thank you, it looks good to me.
A small clarification: if this config is not explicitly set, DataFusion defaults to 100 GB rather than unlimited.
Test result:
yongting@Mac ~/C/d/datafusion-cli (pr-15586) [1]> cargo run --profile release-nonlto -- --mem-pool-type fair --memory-limit 100M --disk-limit 10M -c 'select * from generate_series(1, 1000000000) as t1(v1) order by v1'
Finished `release-nonlto` profile [optimized] target(s) in 0.12s
Running `/Users/yongting/Code/datafusion/target/release-nonlto/datafusion-cli --mem-pool-type fair --memory-limit 100M --disk-limit 10M -c 'select * from generate_series(1, 1000000000) as t1(v1) order by v1'`
DataFusion CLI v46.0.1
Error: Resources exhausted: The used disk space during the spilling process has exceeded the allowable limit of 10.0 MB. Try increasing the `max_temp_directory_size` in the disk manager configuration.
datafusion-cli/src/main.rs
Outdated
| #[clap( | ||
| short = 'd', | ||
| long, | ||
| help = "Available disk space for spilling queries (e.g. '10g'), default to None (no limit)", |
There was a problem hiding this comment.
Suggested change
| help = "Available disk space for spilling queries (e.g. '10g'), default to None (no limit)", | |
| help = "Available disk space for spilling queries (e.g. '10g'), default to None (use DataFusion's default value of '100g')", |
docs/source/user-guide/cli/usage.md
Outdated
| Specify the memory pool type 'greedy' or 'fair', default to 'greedy' | ||
|
|
||
| -d, --disk-limit <DISK_LIMIT> | ||
| Available disk space for spilling queries (e.g. '10g'), default to None (no limit) |
There was a problem hiding this comment.
Suggested change
| Available disk space for spilling queries (e.g. '10g'), default to None (no limit) | |
| Available disk space for spilling queries (e.g. '10g'), default to None (use DataFusion's default value of '100g') |
nirnayroy
pushed a commit
to nirnayroy/datafusion
that referenced
this pull request
May 2, 2025
* added disk limit option * run prettier and cargo fmt * help line update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #15553.
Rationale for this change
Allows users to specify a disk limit for spill queries.
What changes are included in this PR?
A CLI option for users to specify a disk limit.
Are these changes tested?
Are there any user-facing changes?
Yes, new CLI option in
datafusion-cli.