Actually run wasm test in ci #15595
Actually run wasm test in ci #15595
Conversation
github-actions
bot
added
the
development-process
|
I don't fully understand why the testing drivers keep getting killed. It works on my local machine and on other CI..https://github.com/rustwasm/gloo/blob/master/.github/workflows/tests.yml#L79 Will take a closer look later today |
|
I apologize for the super long CI tuning; it has been one of the worst CI experiences... This chrome testing thing is very difficult to setup because it will SIGKILL if the chrome version doesn't matches with the chrome driver version, making it almost impossible to debug. I eventually switched back to the default chrome driver and default chrome, which uses the default runner image environment: https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2404-Readme.md#browsers-and-drivers I think it's not great to have this task running in a separate env setup, but it has been a huge pain to make it work; anyone feel free to improve it... |
|
Thank you @XiangpengHao -- I also find CI debugging very long and painful |
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you @XiangpengHao
I double chekced the action works: https://github.com/apache/datafusion/actions/runs/14285896146/job/40040931834?pr=15595
Also, cc @jonmmease who I think contributed the original tests for wasm
| working-directory: ./datafusion/wasmtest | ||
| run: wasm-pack build --dev | ||
| run: | | ||
| wasm-pack test --headless --firefox |
|
This could be very helpful for implementing CI for |
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
comphead
left a comment
comphead
left a comment
There was a problem hiding this comment.
lgtm thanks @XiangpengHao
@qstommyshu would you mind creating a ticket? |
* actually run test in ci * tweak ci * try ci again * try ci again * try ci again * setup debug * update * try again * update ci * install jq * update ci * fix ci * update * update * try again * Update .github/workflows/rust.yml Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org> --------- Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
4 participants
Which issue does this PR close?
Related to #13815 #15102
Rationale for this change
While digging into another issue, I realized the wasm test was never actually executed in CI, and thus we don't know whether our previous tests will pass (although they build successfully)
This PR enables running wasm test in CI. I believe headless mode is supported as of 2025.
The snapshot test doesn't seem to support wasm: Supporting wasm-bindgen-test? mitsuhiko/insta#120, so I disabled it and has to use some ugly string match
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?