Remove uneeded binary_op benchmarks #15632
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Apr 8, 2025
| None => false, | ||
| } | ||
| } else { | ||
| bool_and(array).unwrap_or(false) |
There was a problem hiding this comment.
these are benchmarks for arrow functions bool_and and false_count / true_count so I don't think we need them in DataFusion
Dandandan
approved these changes
Apr 8, 2025
|
Thank you @Dandandan and @xudong963 |
nirnayroy
pushed a commit
to nirnayroy/datafusion
that referenced
this pull request
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
ANDandOR#15462Rationale for this change
Some of these benchmarks were written for the wonderful analysis by @acking-you in #15462 of bool_or vs count_ones. While they were helpful for that analysis, they really are micro benchmarks for arrow kernels, not DataFusion so I think they don't belong in this repo.
Since most of the binary.rs operations call into arrow kernels, I didn't think adding more was useful at this time.
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?