add from_slice trait to ease arrow2 migration #1588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Jan 16, 2022
| let array_data = ArrayData::builder(T::DATA_TYPE) | ||
| .len(slice.len()) | ||
| .add_buffer(Buffer::from_slice_ref(&slice)); | ||
| let array_data = unsafe { array_data.build_unchecked() }; |
There was a problem hiding this comment.
I had to double check myself, but I think this is good sound (This is not valid for BooleanType) but BooleanType doesn't implement ArrowPrimitiveType 👍
https://docs.rs/arrow/7.0.0/arrow/datatypes/trait.ArrowPrimitiveType.html
There was a problem hiding this comment.
actually this was copied from the From<Vec part in ArrowPrimitiveType
similar changes can be done for booleans and string arrays but it can happen later
There was a problem hiding this comment.
@alamb support for boolean, str, and bin array types are added in:
houqp
approved these changes
Jan 17, 2022
|
Thank you @jimexist |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
Per #1556 - this trait is added to ease migration to arrow2:
What changes are included in this PR?
Are there any user-facing changes?