Skip to content

Handle FixedSizeList in flatten #15899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Handle FixedSizeList in flatten #15899

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 17 additions & 9 deletions datafusion/functions-nested/src/flatten.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,15 +143,23 @@ impl ScalarUDFImpl for Flatten {
pub fn flatten_inner(args: &[ArrayRef]) -> Result<ArrayRef> {
let [array] = take_function_args("flatten", args)?;

fn inner_list(list: &ArrayRef) -> Result<ArrayRef> {
Ok(if let FixedSizeList(field, _) = list.data_type() {
arrow::compute::cast(&list, &List(Arc::clone(field)))?
} else {
Arc::clone(list)
})
}

match array.data_type() {
List(_) => {
let (field, offsets, values, nulls) =
as_list_array(&array)?.clone().into_parts();

match field.data_type() {
List(_) => {
FixedSizeList(_, _) | List(_) => {
let (inner_field, inner_offsets, inner_values, _) =
as_list_array(&values)?.clone().into_parts();
as_list_array(&inner_list(&values)?)?.clone().into_parts();
let offsets = get_offsets_for_flatten::<i32>(inner_offsets, offsets);
let flattened_array = GenericListArray::<i32>::new(
inner_field,
Expand All @@ -160,22 +168,22 @@ pub fn flatten_inner(args: &[ArrayRef]) -> Result<ArrayRef> {
nulls,
);

Ok(Arc::new(flattened_array) as ArrayRef)
Ok(Arc::new(flattened_array))
}
LargeList(_) => {
exec_err!("flatten does not support type '{:?}'", array.data_type())?
}
_ => Ok(Arc::clone(array) as ArrayRef),
_ => Ok(Arc::clone(array)),
}
}
LargeList(_) => {
let (field, offsets, values, nulls) =
as_large_list_array(&array)?.clone().into_parts();

match field.data_type() {
List(_) => {
FixedSizeList(_, _) | List(_) => {
let (inner_field, inner_offsets, inner_values, _) =
as_list_array(&values)?.clone().into_parts();
as_list_array(&inner_list(&values)?)?.clone().into_parts();
let offsets = get_large_offsets_for_flatten(inner_offsets, offsets);
let flattened_array = GenericListArray::<i64>::new(
inner_field,
Expand All @@ -184,7 +192,7 @@ pub fn flatten_inner(args: &[ArrayRef]) -> Result<ArrayRef> {
nulls,
);

Ok(Arc::new(flattened_array) as ArrayRef)
Ok(Arc::new(flattened_array))
}
LargeList(_) => {
let (inner_field, inner_offsets, inner_values, nulls) =
Expand All @@ -197,9 +205,9 @@ pub fn flatten_inner(args: &[ArrayRef]) -> Result<ArrayRef> {
nulls,
);

Ok(Arc::new(flattened_array) as ArrayRef)
Ok(Arc::new(flattened_array))
}
_ => Ok(Arc::clone(array) as ArrayRef),
_ => Ok(Arc::clone(array)),
}
}
Null => Ok(Arc::clone(array)),
Expand Down