-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Add test that demonstrate behavior for collect_statistics
#16098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
125 changes: 125 additions & 0 deletions
125
datafusion/sqllogictest/test_files/parquet_statistics.slt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,125 @@ | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
|
|
||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| # Unless required by applicable law or agreed to in writing, | ||
| # software distributed under the License is distributed on an | ||
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
|
|
||
| # Tests for statistics in parquet files. | ||
| # Writes data into two files: | ||
| # * test_table/0.parquet | ||
| # * test_table/1.parquet | ||
| # | ||
| # And verifies statistics are correctly calculated for the table | ||
| # | ||
| # NOTE that statistics are ONLY gathered when the table is first created | ||
| # so the table must be recreated to see the effects of the setting | ||
|
|
||
| query I | ||
| COPY (values (1), (2), (3)) | ||
| TO 'test_files/scratch/parquet_statistics/test_table/0.parquet' | ||
| STORED AS PARQUET; | ||
| ---- | ||
| 3 | ||
|
|
||
| query I | ||
| COPY (values (3), (4)) | ||
| TO 'test_files/scratch/parquet_statistics/test_table/1.parquet' | ||
| STORED AS PARQUET; | ||
| ---- | ||
| 2 | ||
|
|
||
| statement ok | ||
| set datafusion.explain.physical_plan_only = true; | ||
|
|
||
| statement ok | ||
| set datafusion.explain.show_statistics = true; | ||
|
|
||
| ###### | ||
| # By default, the statistics are not gathered | ||
| ###### | ||
|
|
||
| # Recreate the table to pick up the current setting | ||
| statement ok | ||
| CREATE EXTERNAL TABLE test_table | ||
| STORED AS PARQUET | ||
| LOCATION 'test_files/scratch/parquet_statistics/test_table'; | ||
|
|
||
| query TT | ||
| EXPLAIN SELECT * FROM test_table WHERE column1 = 1; | ||
| ---- | ||
| physical_plan | ||
| 01)CoalesceBatchesExec: target_batch_size=8192, statistics=[Rows=Absent, Bytes=Absent, [(Col[0]:)]] | ||
| 02)--FilterExec: column1@0 = 1, statistics=[Rows=Absent, Bytes=Absent, [(Col[0]: Min=Exact(Int64(1)) Max=Exact(Int64(1)))]] | ||
| 03)----RepartitionExec: partitioning=RoundRobinBatch(4), input_partitions=2, statistics=[Rows=Absent, Bytes=Absent, [(Col[0]:)]] | ||
| 04)------DataSourceExec: file_groups={2 groups: [[WORKSPACE_ROOT/datafusion/sqllogictest/test_files/scratch/parquet_statistics/test_table/0.parquet], [WORKSPACE_ROOT/datafusion/sqllogictest/test_files/scratch/parquet_statistics/test_table/1.parquet]]}, projection=[column1], file_type=parquet, predicate=column1@0 = 1, pruning_predicate=column1_null_count@2 != row_count@3 AND column1_min@0 <= 1 AND 1 <= column1_max@1, required_guarantees=[column1 in (1)] | ||
| 05), statistics=[Rows=Absent, Bytes=Absent, [(Col[0]:)]] | ||
|
|
||
| # cleanup | ||
| statement ok | ||
| DROP TABLE test_table; | ||
|
|
||
| ###### | ||
| # When the setting is true, the statistics are gathered | ||
| ###### | ||
|
|
||
| statement ok | ||
| set datafusion.execution.collect_statistics = true; | ||
|
|
||
| # Recreate the table to pick up the current setting | ||
| statement ok | ||
| CREATE EXTERNAL TABLE test_table | ||
| STORED AS PARQUET | ||
| LOCATION 'test_files/scratch/parquet_statistics/test_table'; | ||
|
|
||
| query TT | ||
| EXPLAIN SELECT * FROM test_table WHERE column1 = 1; | ||
| ---- | ||
| physical_plan | ||
| 01)CoalesceBatchesExec: target_batch_size=8192, statistics=[Rows=Inexact(2), Bytes=Inexact(44), [(Col[0]: Min=Exact(Int64(1)) Max=Exact(Int64(1)) Null=Inexact(0))]] | ||
| 02)--FilterExec: column1@0 = 1, statistics=[Rows=Inexact(2), Bytes=Inexact(44), [(Col[0]: Min=Exact(Int64(1)) Max=Exact(Int64(1)) Null=Inexact(0))]] | ||
| 03)----RepartitionExec: partitioning=RoundRobinBatch(4), input_partitions=2, statistics=[Rows=Inexact(5), Bytes=Inexact(173), [(Col[0]: Min=Inexact(Int64(1)) Max=Inexact(Int64(4)) Null=Inexact(0))]] | ||
| 04)------DataSourceExec: file_groups={2 groups: [[WORKSPACE_ROOT/datafusion/sqllogictest/test_files/scratch/parquet_statistics/test_table/0.parquet], [WORKSPACE_ROOT/datafusion/sqllogictest/test_files/scratch/parquet_statistics/test_table/1.parquet]]}, projection=[column1], file_type=parquet, predicate=column1@0 = 1, pruning_predicate=column1_null_count@2 != row_count@3 AND column1_min@0 <= 1 AND 1 <= column1_max@1, required_guarantees=[column1 in (1)] | ||
| 05), statistics=[Rows=Inexact(5), Bytes=Inexact(173), [(Col[0]: Min=Inexact(Int64(1)) Max=Inexact(Int64(4)) Null=Inexact(0))]] | ||
|
|
||
| # cleanup | ||
| statement ok | ||
| DROP TABLE test_table; | ||
|
|
||
|
|
||
| ###### | ||
| # When the setting is false, the statistics are NOT gathered | ||
| ###### | ||
|
|
||
| statement ok | ||
| set datafusion.execution.collect_statistics = false; | ||
|
|
||
| # Recreate the table to pick up the current setting | ||
| statement ok | ||
| CREATE EXTERNAL TABLE test_table | ||
| STORED AS PARQUET | ||
| LOCATION 'test_files/scratch/parquet_statistics/test_table'; | ||
|
|
||
| query TT | ||
| EXPLAIN SELECT * FROM test_table WHERE column1 = 1; | ||
| ---- | ||
| physical_plan | ||
| 01)CoalesceBatchesExec: target_batch_size=8192, statistics=[Rows=Absent, Bytes=Absent, [(Col[0]:)]] | ||
| 02)--FilterExec: column1@0 = 1, statistics=[Rows=Absent, Bytes=Absent, [(Col[0]: Min=Exact(Int64(1)) Max=Exact(Int64(1)))]] | ||
| 03)----RepartitionExec: partitioning=RoundRobinBatch(4), input_partitions=2, statistics=[Rows=Absent, Bytes=Absent, [(Col[0]:)]] | ||
| 04)------DataSourceExec: file_groups={2 groups: [[WORKSPACE_ROOT/datafusion/sqllogictest/test_files/scratch/parquet_statistics/test_table/0.parquet], [WORKSPACE_ROOT/datafusion/sqllogictest/test_files/scratch/parquet_statistics/test_table/1.parquet]]}, projection=[column1], file_type=parquet, predicate=column1@0 = 1, pruning_predicate=column1_null_count@2 != row_count@3 AND column1_min@0 <= 1 AND 1 <= column1_max@1, required_guarantees=[column1 in (1)] | ||
| 05), statistics=[Rows=Absent, Bytes=Absent, [(Col[0]:)]] | ||
|
|
||
| # cleanup | ||
| statement ok | ||
| DROP TABLE test_table; | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this shows that statistics are not gathered by default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm yeah I see. The original issue I encountered is that
ListingTablevia Rust APIs certainly does collect statistics by default - I thought I then found that it didn't respect the config but maybe that last part was wrong.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update is I think it may be this issue reported by @davisp #15908