Skip to content

Conversation

@melroy12
Copy link
Contributor

@melroy12 melroy12 commented Jul 2, 2025

Which issue does this PR close?

Rationale for this change

Improve build times.

What changes are included in this PR?

Rust 1.88.0 is properly configured and active
All toolchain components (rustfmt, clippy) are working
The DataFusion workspace compiles cleanly with the new Rust version
No warnings or errors detected

Are these changes tested?

Are there any user-facing changes?

@alamb
Copy link
Contributor

alamb commented Jul 3, 2025

Thanks @melroy12 -- I started the CI tests

I suspect this PR will fail at least clippy -- you'll perhaps have to run Clippy and make the changes it suggests (note you can also do clippy --fix which will fix some issues)

@alamb alamb changed the title rustup version Update to Rust 188 Jul 3, 2025
@alamb alamb changed the title Update to Rust 188 Update to Rust 1.88 Jul 3, 2025
@melroy12
Copy link
Contributor Author

melroy12 commented Jul 3, 2025

Thanks @melroy12 -- I started the CI tests

I suspect this PR will fail at least clippy -- you'll perhaps have to run Clippy and make the changes it suggests (note you can also do clippy --fix which will fix some issues)

I did check before pushing the code , I couldn't find any warnings @alamb

@Dandandan Dandandan merged commit aadb79b into apache:main Jul 4, 2025
27 checks passed
@alamb
Copy link
Contributor

alamb commented Jul 5, 2025

Thanks @melroy12 -- I started the CI tests
I suspect this PR will fail at least clippy -- you'll perhaps have to run Clippy and make the changes it suggests (note you can also do clippy --fix which will fix some issues)

I did check before pushing the code , I couldn't find any warnings @alamb

Looks like we have already addressed the clippy errors in previous PRs. Thank you @melroy12 and @Dandandan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update workspace to use Rust 1.88

3 participants