Skip to content

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jul 6, 2025

Which issue does this PR close?

Rationale for this change

@JigaoLuo notes in #16374 (comment) that it may not be clear this approach can be used for any type of index, so let's try and make that clearer in the comments

What changes are included in this PR?

  1. Add some more comments to datafusion-examples/examples/parquet_embedded_index.rs clarifying the scope of the available indexes

Are these changes tested?

By CI

Are there any user-facing changes?

Just docs

Copy link
Contributor

@zhuqi-lucas zhuqi-lucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thank you @alamb !

Copy link
Member

@xudong963 xudong963 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @alamb

@alamb alamb merged commit 1e7c3a1 into apache:main Jul 7, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants