Bump the MSRV to 1.85.1 due to transitive dependencies (aws-sdk)
#16728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datafusion-cli depends on aws-config which has some transitive dependencies which require 1.85. This was a dependabot upgrade in 8366d6e 16:18:43 error: rustc 1.83.0 is not supported by the following packages: 16:18:43 aws-sdk-sso@1.74.0 requires rustc 1.85.0 16:18:43 aws-sdk-ssooidc@1.75.0 requires rustc 1.85.0 16:18:43 aws-sdk-sts@1.76.0 requires rustc 1.85.0 16:18:43 Either upgrade rustc or select compatible dependency versions with ```16:18:43 error: rustc 1.83.0 is not supported by the following packages: 16:18:43 aws-sdk-sso@1.74.0 requires rustc 1.85.0 16:18:43 aws-sdk-ssooidc@1.75.0 requires rustc 1.85.0 16:18:43 aws-sdk-sts@1.76.0 requires rustc 1.85.0 ``` The AWS SDK for Rust team takes a pretty lenient approach with MSRV upgrades and doesn't really treat them as breaking which is why aws-config
comphead
reviewed
Jul 9, 2025
There was a problem hiding this comment.
Thanks @rtyler
Reg to https://datafusion.apache.org/user-guide/introduction.html#rust-version-compatibility-policy
we support stable rustc versions for last 4 months. 1.85 https://releases.rs/docs/1.85.0/ released Feb20 and we can support it, but since we got a hot fix 1.85.1 we have to use the hot fix
comphead
reviewed
Jul 9, 2025
Co-authored-by: Oleks V <comphead@users.noreply.github.com>
comphead
approved these changes
Jul 9, 2025
alamb
changed the title
1.85.1 due to transitive dependencies (aws-sdk
alamb
changed the title
1.85.1 due to transitive dependencies (aws-sdk1.85.1 due to transitive dependencies (aws-sdk)
|
I hit this during the delta-rs upgrade, so I made a PR proposing a note in the upgrade guide: |
lidavidm
pushed a commit
to apache/arrow-adbc
that referenced
this pull request
Aug 4, 2025
…srv (#3228) Supersede #3210 Context: apache/datafusion#16728
gabotechs
added a commit
to gabotechs/datafusion
that referenced
this pull request
Aug 4, 2025
This reverts commit bd8fd29.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
datafusion-cli depends on aws-config which has some transitive dependencies which require 1.85. This was a dependabot upgrade in 8366d6e
16:18:43 error: rustc 1.83.0 is not supported by the following packages:
16:18:43 aws-sdk-sso@1.74.0 requires rustc 1.85.0
16:18:43 aws-sdk-ssooidc@1.75.0 requires rustc 1.85.0
16:18:43 aws-sdk-sts@1.76.0 requires rustc 1.85.0
16:18:43 Either upgrade rustc or select compatible dependency versions with
The AWS SDK for Rust team takes a pretty lenient approach with MSRV upgrades and doesn't really treat them as breaking which is why aws-config
We could probably take this or bump back down to aws-config
=1.8.0