Skip to content

Conversation

@ajita-asthana
Copy link
Contributor

@ajita-asthana ajita-asthana commented Jul 10, 2025

Which issue does this PR close?

Rationale for this change

Add a benchmark to measure char performance, can be reviewed once the char.rs implementation is merged.

What changes are included in this PR?

adds a new file in benches directory.

Are these changes tested?

Are there any user-facing changes?

Nil

@github-actions github-actions bot added the functions Changes to functions implementation label Jul 10, 2025
Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ajita-asthana for your first contribution
I think it would be great having a bench for char function.

@comphead
Copy link
Contributor

I changed PR header to related instead of closed as the #16009 expects both bench and optimization implementation which I believe is another your PR #16076

@ajita-asthana
Copy link
Contributor Author

Thanks @comphead I will fix the linux build failure.

@github-actions github-actions bot added spark and removed functions Changes to functions implementation labels Jul 12, 2025
@ajita-asthana ajita-asthana requested a review from comphead July 12, 2025 22:41
@ajita-asthana
Copy link
Contributor Author

ajita-asthana commented Jul 13, 2025

char             
                        time:   [18.805 µs 19.026 µs 19.274 µs]
                        change: [+339.25% +341.54% +344.44%] (p = 0.00 < 0.05)

Copy link
Contributor

@crepererum crepererum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@crepererum crepererum merged commit 44e63e0 into apache:main Jul 17, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants