feat(spark): implement Spark math function rint #16924
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Jul 27, 2025
There was a problem hiding this comment.
Looks good to me
@shehabgamin and @comphead in case you would like a chance to review too
|
Thank you for driving this @chenkovsky |
shehabgamin
approved these changes
Jul 29, 2025
| pub fn new() -> Self { | ||
| Self { | ||
| signature: Signature::one_of( | ||
| vec![Exact(vec![Float64]), Exact(vec![Float32])], |
There was a problem hiding this comment.
According to these docs, the input type might be a little bit more flexible?
https://docs.databricks.com/aws/en/sql/language-manual/functions/rint#arguments
There was a problem hiding this comment.
I added more types. please review it again
comphead
reviewed
Jul 29, 2025
|
|
||
| fn output_ordering(&self, input: &[ExprProperties]) -> Result<SortProperties> { | ||
| // round preserves the order of the first argument | ||
| let value = &input[0]; |
There was a problem hiding this comment.
it is good to check is not empy
comphead
approved these changes
Jul 29, 2025
|
Thanks @chenkovsky and @comphead and @shehabgamin |
Standing-Man
pushed a commit
to Standing-Man/datafusion
that referenced
this pull request
Aug 4, 2025
* feat: spark rint * support all numeric * update * check empty for output ordering
54 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
What changes are included in this PR?
implement spark rint udf
Are these changes tested?
UT
Are there any user-facing changes?
No