Implement Spark url function parse_url
#16937
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Standing-Man
changed the title
url function parse_url
alamb
reviewed
Jul 28, 2025
There was a problem hiding this comment.
Thank you @Standing-Man -- I have a suggestion to try and avoid 27 copies. Let me know what you think
Standing-Man
commented
Jul 30, 2025
Standing-Man
commented
Jul 30, 2025
Standing-Man
force-pushed
the
parse-url
branch
2 times, most recently
from
27c71ce to
e316acc
Compare
Standing-Man
force-pushed
the
parse-url
branch
2 times, most recently
from
ae73d75 to
acc558e
Compare
|
Hi @alamb, Quick ping on this PR — any feedback would be great! |
Signed-off-by: Alan Tang <jmtangcs@gmail.com>
Signed-off-by: Alan Tang <jmtangcs@gmail.com>
Signed-off-by: Alan Tang <jmtangcs@gmail.com>
Signed-off-by: Alan Tang <jmtangcs@gmail.com>
alamb
approved these changes
Aug 6, 2025
|
Thank you for reviewing this PR and providing valuable feedback. |
54 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
datafusion-sparkSpark Compatible Functions #15914.Rationale for this change
What changes are included in this PR?
Implement Spark
urlfunctionparse_urlAre these changes tested?
Yes
Are there any user-facing changes?
Yes