Implment Spark map function map
#16940
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alan Tang <jmtangcs@gmail.com>
Standing-Man
force-pushed
the
map-function
branch
from
4fe3177 to
e33302f
Compare
54 tasks
|
Hi @alamb, no rush, but when you have some time, I’d love your review on this PR. Thanks in advance! |
| let keys = args.keys().map(|a| a.as_ref()).collect::<Vec<_>>(); | ||
| let values = args.values().map(|a| a.as_ref()).collect::<Vec<_>>(); | ||
| if keys.iter().any(|a| a.data_type() != key_type) { | ||
| return exec_err!("map requires all key types to be the same"); |
There was a problem hiding this comment.
please consider checking this implementation:
https://github.com/lakehq/sail/blob/0a82099c61cf29e9cdfa33666955e55b37a2256a/crates/sail-plan/src/function/scalar/map.rs#L8
https://github.com/lakehq/sail/blob/0a82099c61cf29e9cdfa33666955e55b37a2256a/crates/sail-plan/src/extension/function/map/map_function.rs#L15
it supports:
- type coersion for keys and values
- empty map creation
- keys deduplication
- map creation from values, arrays and entries
and passes spark-tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
datafusion-sparkSpark Compatible Functions #15914.Rationale for this change
What changes are included in this PR?
Implment Spark
mapfunctionmapAre these changes tested?
Yes
Are there any user-facing changes?
Yes